Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base folder under some module views folder #635

Closed
dmanners opened this issue Aug 19, 2014 · 6 comments
Closed

Base folder under some module views folder #635

dmanners opened this issue Aug 19, 2014 · 6 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@dmanners
Copy link
Contributor

What is with the base folder under some of the view folders for modules? As far as I can see, according to the documents at https://wiki.magento.com/display/MAGE2DOC/Magento+2+Product+Documentation the folders under view are normally the areas: adminhtml, frontend etc.

I would suggest if these folder can be areas and other items like themse etc that this could cause some confusion.

An example of this is Mage\Bundle\view\base here there are layout and template files

@ilol
Copy link

ilol commented Aug 20, 2014

@dmanners thanks, we would consider your suggestion

@dmanners
Copy link
Contributor Author

@ilol do you know if this "base" folder is a direct relation to the base template folder under Magento1?

@buskamuza
Copy link
Contributor

@dmanners , "base" folder includes view files common for all areas. I agree that it may intersect with area named "base".

@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-28241

@ilol ilol added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 18, 2015
tang-yu pushed a commit that referenced this issue Sep 29, 2015
[FearlessKiwis] Sprint 55: Bug fixes
@piotrekkaminski
Copy link
Contributor

This is currently not a priority but asked architects for evaluation.

magento-team pushed a commit that referenced this issue May 17, 2016
@piotrekkaminski piotrekkaminski removed their assignment Aug 22, 2016
@piotrekkaminski
Copy link
Contributor

Thank you for your submission.

We recently made some changes to the way we process GitHub submissions to more quickly identify and respond to core code issues.

Feature Requests and Improvements should now be submitted to the new Magento 2 Feature Requests and Improvements forum (see details here).

We are closing this GitHub ticket and have moved your request to the new forum.

okorshenko pushed a commit that referenced this issue Dec 14, 2016
[South] Bugs 2.1:
- MAGETWO-56998 [Backport] Simple child product without a special price still shown as "was (original price)" #4442 #5097 #6645 - for 2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

6 participants