Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greek vat numbers cannot be validated #6960

Closed
schnappenberger opened this issue Oct 11, 2016 · 8 comments
Closed

Greek vat numbers cannot be validated #6960

schnappenberger opened this issue Oct 11, 2016 · 8 comments
Labels
bug report Component: Checkout Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted

Comments

@schnappenberger
Copy link

Validation of vat numbers use country code to build a vat number for vat validation. But greek vat numbers start with EL instead of GR.

Preconditions

  1. Magento 2.1.1
  2. PHP7
  3. Mysql 5
  4. Apache 2

Steps to reproduce

  1. login in frontend
  2. enter a valif greek vat id
  3. let magento validate the vat number

Expected result

  1. correct vat numbers should be validated

Actual result

  1. vat number validation fails
@sevos1984
Copy link
Contributor

Internal ticket created MAGETWO-59636. Thanks for posting

@sevos1984 sevos1984 added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 12, 2016
@cmuench
Copy link
Contributor

cmuench commented Feb 15, 2017

Any updates here? We have the same problem with a valid the german VAT.
If i remove the "DE" prefix it passes the validation. After the validation the "DE" prefix is automatically prepended. If i save my billing address again in the customer area the validation fails again.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Checkout Component: Customer Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

@schnappenberger, thank you for your report.
We've created internal ticket(s) MAGETWO-59636 to track progress on the issue.

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed 2.2.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 6, 2017
@magento-engcom-team
Copy link
Contributor

Hi @schnappenberger

This ticket has been marked as "Triage Wanted" due to low user involvement over time. Over the next 2 weeks we are looking for additional community feedback to decide if it should be archived or not. More information on this is available on the GitHub wiki.

Thank you for collaboration.

@magento-engcom-team
Copy link
Contributor

@schnappenberger thank you for your report.

Unfortunately, we are archiving this ticket now as it did not get much attention from both Magento Community and Core developers for an extended period. This is done in an effort to create a quality, community-driven backlog which will allow us to allocate the required attention more easily.

You may learn more about this initiative following this link.

Please feel free to comment or reopen the ticket if you think it should be reviewed once more. Thank you for collaboration.

@hostep
Copy link
Contributor

hostep commented Jan 23, 2019

Re-opening, because a customer of ours runs against this problem with the incorrect Greek prefix.
I'm currently preparing a PR to fix this.

@cmuench: I think the issue you are experiencing is not the same, but might have been fixed by: #17385

@hostep hostep reopened this Jan 23, 2019
@magento-engcom-team
Copy link
Contributor

Hi @schnappenberger. Thank you for your report.
The issue has been fixed in #20548 by @hostep in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.1 release.

@magento-engcom-team
Copy link
Contributor

Hi @schnappenberger. Thank you for your report.
The issue has been fixed in #21169 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.9 release.

mmansoor-magento pushed a commit that referenced this issue Aug 10, 2021
[EngCom] AC-292 - Added strict laminas escaper version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Checkout Component: Customer Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release triage wanted
Projects
None yet
Development

No branches or pull requests

6 participants