Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Malta zipcode validation incomplete #8863

Closed
wigman opened this issue Mar 13, 2017 · 3 comments
Closed

Malta zipcode validation incomplete #8863

wigman opened this issue Mar 13, 2017 · 3 comments
Assignees
@mmacinko
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@wigman
Copy link
Contributor

wigman commented Mar 13, 2017

Zip code validation fails on adresses from Malta when containing 4 numbers (ABC 1234).

Preconditions

On all 2.* versions including development branch.

Steps to reproduce

go to cart or checkout and insert ABC 1234. Validation fails

Expected result

Validation should succeed.

Actual result

Validation fails

Solution

insert an extra validation rule containing <code id="pattern_X" active="true" example="ABC 1234">^[a-zA-Z]{3}\s[0-9]{4}$</code>
at

magento2/app/code/Magento/Directory/etc/zip_codes.xml

Line 281 in cec25e1

<code id="pattern_2" active="true" example="ABC 12">^[a-zA-Z]{3}\s[0-9]{2}$</code>

@ishakhsuvarov ishakhsuvarov self-assigned this Mar 14, 2017
@ishakhsuvarov ishakhsuvarov added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 16, 2017
@mmacinko
Copy link

Issue in progress @mmacinko

mmacinko pushed a commit to mmacinko/magento2 that referenced this issue Mar 16, 2017
magento#8863: Malta zipcode validation incomplete
847b95b
@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team
Copy link
Contributor

@wigman thank you for your report.
The fix for this issue is already available in release 2.2.0

@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Sep 20, 2017
@wigman
Copy link
Contributor Author

wigman commented Sep 22, 2017

"already"

magento-devops-reposync-svc pushed a commit that referenced this issue Apr 9, 2024
@sidolov
Merge pull request #8863 from magento-gl/spartans_pr_29032024_AC-11661
017ec8b 
[Spartans] Bugfix Delivery
magento-devops-reposync-svc pushed a commit that referenced this issue Oct 8, 2024
@sidolov
Merge pull request #8863 from magento-gl/spartans_pr_29032024_AC-11661
d3ff603 
[Spartans] Bugfix Delivery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmacinko mmacinko

Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mmacinko @wigman @ishakhsuvarov @magento-engcom-team