Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to change "shipping setting" in backed when a profiler is enabled. #8890

Closed
phoenix128 opened this issue Mar 15, 2017 · 2 comments
Closed
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@phoenix128
Copy link
Contributor

Preconditions

  1. Magento 2.1.3
  2. PHP 7

Steps to reproduce

  1. Enable MAGE_PROFILER directive to any value (e.g.: Magento\Framework\Profiler\Driver\Standard\Output\Firebug or Magento\Framework\Profiler\Driver\Standard\Output\Html)
  2. Open admin panel
  3. Go to Stores > Configuration > Sales > Shipping Settings

Expected result

  1. Page should just open

Actual result

  1. Error 500 on /admin/directory/json/countryRegion call
  2. Admin redirects to dashboard

My debug:

First error (unalbe to use a custom profiler):

In \Magento\Framework\Profiler::_parseConfig you hardcoded "firebug" as default value for ajax calls. This overrides any kind of custom configuration I would apply.

Second error (error 500 in ajax call):

In \Magento\Framework\Profiler\Driver\Standard\Output\Firebug::display() you are referring to $this->getResponse() at line 61. But it is empty.

@phoenix128
Copy link
Contributor Author

Why this issue has been closed? Do you have problems reproducing it?

@magento-engcom-team magento-engcom-team added G1 Passed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed G1 Passed labels Sep 5, 2017
@magento-engcom-team magento-engcom-team added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Oct 5, 2017
@magento-engcom-team
Copy link
Contributor

@phoenix128, thank you for your report.
The issue is already fixed in 2.2.0

@magento-engcom-team magento-engcom-team added 2.1.x Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed in 2.2.x The issue has been fixed in 2.2 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Development

No branches or pull requests

2 participants