Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.1-backport] Customer-data is not updates after login when full page cache disabled #10050

Merged
merged 2 commits into from
Jun 27, 2017

Conversation

ihor-sviziev
Copy link
Contributor

@ihor-sviziev ihor-sviziev commented Jun 26, 2017

Description

If you disable full page cache (tested with built-in) - after login

Preconditions

  1. Magento 2.1.1
  2. Full page cache is in "Disabled" state (via php bin/magento cache:disable full_page)
  3. Google Chrome latest

Steps to reproduce

  1. Go to magento website
  2. Try to login
  3. See welcome message

Expected result

  1. Welcome message should be "Welcome, !"
  2. Customer data should contains customer information

Actual result

  1. Welcome message is "Default welcome msg!"
    image
  2. Customer data isn't contains customer information

Fixed Issues (if relevant)

  1. Magento2 Mini Cart Items Issue #4170 : Magento2 Mini Cart Items Issue
  2. Minicart empty if FPC disabled in Magneto 2.1.1 #6882 : Minicart empty if FPC disabled in Magneto 2.1.1
  3. "No items" in minicart in 2.1 #5377: "No items" in minicart in 2.1
  4. Customer-data is not updates after login when full page cache disabled #6473 : Customer-data is not updates after login when full page cache disabled

These changes were already applied in develop branch, so this PR will fix this issue for 2.1.x.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Serhiy Shkolyarenko added 2 commits June 26, 2017 13:12
…te minicart info

test fix

(cherry picked from commit 9efb5ad)
@ishakhsuvarov ishakhsuvarov self-assigned this Jun 26, 2017
@ishakhsuvarov ishakhsuvarov added this to the June 2017 milestone Jun 26, 2017
@magento-team magento-team merged commit f49e937 into magento:2.1-develop Jun 27, 2017
magento-team pushed a commit that referenced this pull request Jun 27, 2017
@ihor-sviziev ihor-sviziev deleted the patch-7 branch June 27, 2017 18:56
@ihor-sviziev
Copy link
Contributor Author

Hi @wert2all why this change wasn't added to 2.1.8-preview? Are there any issues? Is it possible to add it to final release?

@ishakhsuvarov
Copy link
Contributor

@ihor-sviziev Looks like by the time this PR was processed 2.1.8-preview was already in testing. To maintain quality we stop adding new commits after testing has started.

@ihor-sviziev
Copy link
Contributor Author

ihor-sviziev commented Jul 6, 2017

@ishakhsuvarov thx for clarification. Will it be added to 2.1.8 release or that means all non-merged changes will not be included?

@ishakhsuvarov
Copy link
Contributor

@ihor-sviziev I can not give precise information at the moment, but most likely it will not be included. I will provide update as soon as I know for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants