Google Sitemap refactoring - introduce item resolver

[piotrkwiecinski]

Refactoring to introduce injectable item resolver as way to add items to sitemap

Description

• Introduce SitemapItemResolverInterface with concrete implementations for cms pages, products, categories and aggregate
• Introduce SitemapItemInterface as representation of single sitemap item
• Introduce SitemapConfigReaderInterface
• Introduce SitemapItemResolverConfigInterface
• Remove addSitemapItems as it was introduced in develop branch and wasn't used yet as public API
• Deprecate helper (suggested by @vrann). Getting data from configuration is part of introduced concrete implementations.

Fixed Issues (if relevant)

1. Refactoring: Adding items to the Sitemap #10045: Refactoring: Adding items to the Sitemap

Manual testing scenarios

1. Go to Marketing > SEO > Sitemap
2. Add sitemap - provide path and filename
3. Click generate & save sitemap
4. Check if content is properly generated.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[okorshenko]

Hi @piotrkwiecinski Could you please look at broken tests?

[piotrkwiecinski]

@vrann, @okorshenko tests should be green now. Last one was static.

[vrann]

@piotrkwiecinski finished code review, looks good. Running internal builds.

[vrann]

Please restore these two public methods:

• they are in the class marked as @api
• the class will be released as is in 2.2 release
• current pull request will get to the 2.3 release

[Ctucker9233]

@magento-team Will this get backported to 2.2?

[piotrkwiecinski]

If it would be useful and there is no objections from @magento-team I could port it back on Monday or Tuesday

[Ctucker9233]

@piotrekkaminski Thanks