Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for issue 1035 #1043

Merged

Commits on Feb 15, 2015

  1. Bug fix for issue 1035

    magento#1035
    
    A bug in the appendNode method of Magento\Framework\Simplexml\Element.php causes values to be lost in very specific cases. This will fix it. The existing unit test for appendNode has been updated as well.
    
    Bug: When appending a node that has an attribute and no child nodes, the code will take the code path for having children. This is because the result of $source->children() evaluates to TRUE when a node has attributes and no children.
    
    Fix: Changing to call from [children()] to [count()] fixes the issue.
    tim-reynolds committed Feb 15, 2015
    Configuration menu
    Copy the full SHA
    4a92a64 View commit details
    Browse the repository at this point in the history