Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove decoder interface usage #10453

Merged
merged 3 commits into from
Aug 8, 2017
Merged

Remove decoder interface usage #10453

merged 3 commits into from
Aug 8, 2017

Conversation

dmanners
Copy link
Contributor

@dmanners dmanners commented Aug 7, 2017 •
edited by okorshenko
Loading

Description

Since the DecoderInterface in deprecated we can start to remove the usage with \Magento\Framework\Serialize\Serializer\Json instead.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners
Replace the usage of Magento\Framework\Json\DecoderInterface in the B…
e9fa41e 
…ookmark model,

 - deprecate the $jsonDecoder,
 - inject the new \Magento\Framework\Serialize\Serializer\Json
 - replace the usage of $jsonDecoder with the $serializer
@dmanners
Replace the usage of Magento\Framework\Json\DecoderInterface in the b…
075eba8 
…ookmark save controller

 - deprecate $jsonDecoder,
 - inject the new \Magento\Framework\Serialize\Serializer\Json,
 - replace usage of $jsonDecoder with $serializer
@dmanners
Update the docblock for the constructor in the bookmark ui save contr…
0e4a1a3 
…oller
@okorshenko okorshenko self-assigned this Aug 7, 2017
@okorshenko okorshenko added this to the August 2017 milestone Aug 7, 2017
@magento-team magento-team merged commit 0e4a1a3 into magento:develop Aug 8, 2017
magento-team pushed a commit that referenced this pull request Aug 8, 2017
MAGETWO-71392: Remove decoder interface usage #10453
a0b21d3
magento-team pushed a commit that referenced this pull request Aug 8, 2017
@ishakhsuvarov
Merge pull request #1389 from magento-engcom/develop-prs
354fc11 
[EngCom] Public Pull Requests
 - MAGETWO-71392: Remove decoder interface usage #10453
@dmanners dmanners deleted the remove-decoder-interface-usage branch December 19, 2017 13:07
@Ctucker9233
Copy link

@magento-team Will this be backported to 2.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Progress: accept
Projects
None yet
Milestone
August 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@dmanners @Ctucker9233 @magento-team @okorshenko