Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make possible to upload SVG logo by admin #1048

Merged
merged 1 commit into from
Mar 23, 2015
Merged

Make possible to upload SVG logo by admin #1048

merged 1 commit into from
Mar 23, 2015

Conversation

cbmd
Copy link
Contributor

@cbmd cbmd commented Feb 16, 2015

Nowadays it is pretty useful to have an option to upload SVG logo, since this will reduce assets that needs for all different devices to be rendered perfectly.

@vrann
Copy link
Contributor

vrann commented Feb 23, 2015

Hi, @cbmd,
thanks for contribution!
You allow to upload SVG just for Logo. Should this option be available for any Image, so that allowed extensions in the Magento\Backend\Model\Config\Backend\Image is extended on svg as well?

@cbmd
Copy link
Contributor Author

cbmd commented Feb 23, 2015

@vrann I do think that it can be done in more general class, but in case "just for logo" we avoid situations where it can be uploaded for example for products (which is useless usage of image type, as i think). But we could discuss this one with community :)

@cbmd
Copy link
Contributor Author

cbmd commented Feb 23, 2015

So i meant that this type of images should be used carefully, since in some cases it will dramatically increase image size instead of making it better in performance and usability wise...

@vrann
Copy link
Contributor

vrann commented Feb 24, 2015

@cbmd thanks, I see your reasons.

Can you please cover the contribution with tests? It is something we ask contributors to do as a part of https://github.com/magento/magento2/wiki/Contribution-Guide

Tracking number MAGETWO-34527

@vrann vrann added Progress: needs update Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Feb 24, 2015
@vrann vrann self-assigned this Feb 24, 2015
@anupdugar
Copy link
Contributor

@cbmd Any updates on this?

@cbmd
Copy link
Contributor Author

cbmd commented Mar 3, 2015

@anupdugar @vrann Sorry about delay, i will provide them ASAP for sure, busy weeks...

@vpelipenko
Copy link
Contributor

@cbmd, do you have any news for us?

@vrann
Copy link
Contributor

vrann commented Mar 18, 2015

@cbmd this change is covered with the test in internal codebase. We will merge this PR soon. Thanks!

@vrann
Copy link
Contributor

vrann commented Mar 18, 2015

@cbmd can you please make sure that there is no conflicts in the files you contributed with the latest from the mainline. Backend models were moved to the Config module.

@vrann
Copy link
Contributor

vrann commented Mar 20, 2015

@cbmd I've resolved conflict internally. No other changes is need. Please don't do any other change.
This pull request will be merged soon. Thanks!

@magento-team magento-team merged commit 7596d39 into magento:develop Mar 23, 2015
@sshrewz
Copy link

sshrewz commented Mar 23, 2015

@cbmd, this is now included in 0.74.0-beta1. Thank you again for your contribution and continued support in Magento!

magento-team pushed a commit that referenced this pull request Apr 21, 2017
- MAGETWO-65470: The visibility conditions improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants