Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable universal use of modal and tab_group #10789

Merged
merged 2 commits into from
Sep 17, 2017

Conversation

netzkollektiv
Copy link
Contributor

@netzkollektiv netzkollektiv commented Sep 6, 2017

This pull request enables a universal use of modal and tab_group. In detail it allows having tab_group (used in customer edit view) to have child elements which do not need to be validated. Adding a construction like the "related products add"-functionality from catalog product edit via modal was not possible, because the modal inside the tab_group was tried to be validated as a field.

This change request ignores undefined elements in validation, but considers false elements as false and true elements as true.

Description

see above

Manual testing scenarios

  1. add similar construction as add related products fucntionality from catalog product edit in customer product edit
  2. try to save the customer
  3. form will not validate due to undefined error

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 6, 2017

CLA assistant check
All committers have signed the CLA.

@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 6, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Sep 6, 2017
@ishakhsuvarov
Copy link
Contributor

Hi @netzkollektiv
Thank you for your contribution. Please sign the CLA with the email used for the commit, so that we could proceed with processing.
Also it would be nice if you could provide some more detailed code example to simplify review and testing.
Thank you!

@netzkollektiv
Copy link
Contributor Author

netzkollektiv commented Sep 7, 2017

Hi @ishakhsuvarov

I signed it several times, but I always get:

Thank you for signing the CLA!
we are now taking you back to GitHub

and it remains unsigned in github.

Here's a basic example of a adding a new tab including a button and a modal to the customer form:
https://gist.github.com/netzkollektiv/e5bdccc54de3a94cda23aabf69031633

@ishakhsuvarov
Copy link
Contributor

@netzkollektiv

I signed it several times, but I always get

To fix this you should add an email address used for the commit to your github account (may be private).

Thank you

@netzkollektiv
Copy link
Contributor Author

I added the commit email to the netzkollektiv account (was part of my private acc), but it still does not work. What should I do?

@netzkollektiv
Copy link
Contributor Author

@ishakhsuvarov it needs to be the primary email - interesting.
ok, now you should be good to go, right?

@ishakhsuvarov
Copy link
Contributor

@netzkollektiv

needs to be the primary email - interesting

Wasn't aware of that, sorry.

Thank you for the update. We will proceed with review and testing.

@magento-team magento-team merged commit 815be57 into magento:develop Sep 17, 2017
magento-team pushed a commit that referenced this pull request Sep 17, 2017
[EngCom] Public Pull Requests
 - MAGETWO-75310 Fixed Typo Mistake in comment. #10905
 - MAGETWO-75309 Add escaping of js translation version #10904
 - MAGETWO-72341 enable universal use of modal and tab_group #10789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants