Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling mistake in AddressTest.php #10806

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Fix spelling mistake in AddressTest.php #10806

merged 1 commit into from
Sep 8, 2017

Conversation

GitHamo
Copy link
Contributor

@GitHamo GitHamo commented Sep 7, 2017

Added the T to customer which shouldn't affect the test unit as it sets the customer ID later (Line: 88) but it's better to correct the spelling mistake.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 7, 2017

CLA assistant check
All committers have signed the CLA.

@miguelbalparda miguelbalparda self-assigned this Sep 7, 2017
@miguelbalparda miguelbalparda added this to the September 2017 milestone Sep 7, 2017
@miguelbalparda
Copy link
Contributor

Hi @GitHamo! Thank you for your contribution, would you mind signing the CLA so we can process this one?

@GitHamo
Copy link
Contributor Author

GitHamo commented Sep 7, 2017

Thank you very much for your comments. I wonder how can i include similar changes to enterprise edition?

@miguelbalparda
Copy link
Contributor

Are you asking about this very same change or did you find something different in the EE codebase?

@GitHamo
Copy link
Contributor Author

GitHamo commented Sep 7, 2017

I actually found the issue in EE, confirmed and did the changes to CE.

@miguelbalparda
Copy link
Contributor

Very well, thank you very much for that. If I recall correctly there is no direct way to create a PR for the EE code, but I'll ask around and report back.

@magento-team magento-team merged commit 91abdf8 into magento:develop Sep 8, 2017
magento-team pushed a commit that referenced this pull request Sep 8, 2017
[EngCom] Public Pull Requests
 - MAGETWO-72390: Remove the usage of the DataObject for response management #10808
 - MAGETWO-71545: Added 'application/json' Content-Type to Ajax responses in the Magento_UI module. #10521
 - MAGETWO-72388: Fix spelling mistake in AddressTest.php #10806
 - MAGETWO-72283: Code generate: support variadic parameter #10771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants