Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing return statements in setters #11127

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Add missing return statements in setters #11127

merged 1 commit into from
Oct 4, 2017

Conversation

niccifor
Copy link

@niccifor niccifor commented Sep 28, 2017 •
edited
Loading

Description

There were 2 missing return statements in
Magento\Sales\Model\Order\Shipment\ItemCreation setters.

This brakes "fluent interface" suggested in its interface.

magento2/app/code/Magento/Sales/Api/Data/LineItemInterface.php

Line 30 in fa2439c

* @return $this

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vrann vrann self-assigned this Sep 29, 2017
@vrann vrann added this to the September 2017 milestone Sep 29, 2017
@vrann vrann reopened this Sep 29, 2017
@okorshenko okorshenko merged commit 7d5fc25 into magento:2.2-develop Oct 4, 2017
okorshenko pushed a commit that referenced this pull request Oct 4, 2017
@vrann
MAGETWO-80369: Add missing return statements in setters #11127
c640aba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vrann vrann

Labels
Progress: accept Release Line: 2.2
Projects
None yet
Milestone
September 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@niccifor @magento-team @vrann @okorshenko