Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #10317 Disable region list when switching to a region optional country. #11254

Merged
merged 1 commit into from
Oct 6, 2017

Conversation

romainruaud
Copy link
Contributor

@romainruaud romainruaud commented Oct 5, 2017

This is a fix for issue #10317

Description

The PR consist only on disabling the region dropdown element after hiding it when switching to a country not using option based regions.

This prevent the previous value being sent when submitting the form.

Fixed Issues (if relevant)

  1. Region is being overridden when changing from a required-state country to one that is not required #10317: Region is being overridden when changing from a required-state country to one that is not required

Manual testing scenarios

  1. Log into your Account on the frontend
  2. Edit your billing address and save using EUA for country and pick a state (Alaska) , save it.
  3. Edit your billing address again, change from EUA to Uruguay, change the region input for Test
  4. Save it and you will see Test state showed. Without this fix, it would still have shown Alaska.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@romainruaud
Copy link
Contributor Author

@vrann can you flag this one as partner contribution ? Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants