Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2-develop] #11358 Fix full tax summary display breakdown #11447

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

Full Tax Summary display wrong numbers.

Related with PR#11446

Description

Full tax summary breakdown fails, as explained in #11358, solution taken from proposed gist: https://gist.github.com/heyqule/7c830137715544ff95baba50a5ed3d80

Fixed Issues (if relevant)

  1. Full Tax Summary display wrong numbers. #11358: Full Tax Summary display wrong numbers.

Manual testing scenarios

As explained in #11358

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 changed the title [Backport 2.2-develop] Fix full tax summary display breakdown [Backport 2.2-develop] #11358 Fix full tax summary display breakdown Oct 14, 2017
@fooman
Copy link
Contributor

fooman commented Oct 15, 2017

Let's wait on getting this one merged until we have done the PR against develop.

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release labels Nov 7, 2017
@okorshenko okorshenko removed the 2.2.x label Dec 14, 2017
@okorshenko okorshenko added partners-contribution Pull Request is created by Magento Partner and removed partner contribution labels Apr 2, 2018
@orlangur orlangur self-assigned this Jul 11, 2018
@orlangur
Copy link
Contributor

Closing due to inactivity. Feel free to reach me out anytime later if you wish to continue work on this pull request and it will be reopened.

Nowadays we should start from 2.2-develop actually :)

@orlangur orlangur closed this Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partners-contribution Pull Request is created by Magento Partner Progress: on hold Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants