Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227

Merged

Conversation

andrew-garside-temando
Copy link

@andrew-garside-temando andrew-garside-temando commented Nov 14, 2017

Description

Test Magento\Sales\Service\V1\OrderCreateTest has an incorrect shipping method fixture which produces an error when ever something tries to get the orders shipping method as an object.
e.g.
$order->getShippingMethod(true);
Notice: Undefined offset: 1 in /magento2/app/code/Magento/Sales/Model/Order.php on line 1194

Fixed Issues (if relevant)

N/A

Manual testing scenarios

  1. In any order extension or test have $order->getShippingMethod(true);
  2. Current OrderCreateTest produces an error Notice: Undefined offset: 1 in /magento2/app/code/Magento/Sales/Model/Order.php on line 1194

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 14, 2017

CLA assistant check
All committers have signed the CLA.

@fooman fooman self-assigned this Nov 14, 2017
@fooman fooman added this to the November 2017 milestone Nov 14, 2017
@sidolov sidolov self-assigned this Nov 24, 2017
@magento-team magento-team merged commit 149268c into magento:2.2-develop Nov 25, 2017
magento-team pushed a commit that referenced this pull request Nov 25, 2017
magento-team pushed a commit that referenced this pull request Nov 25, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83552: save invoice ID on credit memo when using API method salesRefundInvoiceV1 #11670
 - MAGETWO-82577: [Backport 2.2] Translate order getCreatedAtFormatted() to store locale #11422
 - MAGETWO-84474: 10128: New Orders not being saved to order grid #12241
 - MAGETWO-83783: Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227
 - MAGETWO-83290: Add swatch option: Prevent loosing data and default value if data is not populated via adminhtml #12036
 - MAGETWO-83741: 11740: Sending emails from Admin in Multi-Store Environment defaults to Primary Store #11992
 - MAGETWO-83399: Fix for remove 'product_list_toolbar' block from layout in XML #9413 #11473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants