Fix typo in SINGLE_PRODUCT_LAYOUT_HANLDE

[aschrammel]

The constant SINGLE_PRODUCT_LAYOUT_HANLDE contains a typo. It should be SINGLE_PRODUCT_LAYOUT_HANDLE.

Description

Correct spelling of "handle" in SINGLE_PRODUCT_LAYOUT_HANLDE constant in Magento\Widget\Model\Widget\Instance

Fixed Issues (if relevant)

--

Manual testing scenarios

--

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[dmanners]

Hi @aschrammel. Thanks for the pull request. First thing is first can you sign the CLA and then we can work on accepting this pull request.

[dmanners]

Unfortunately we cannot rename or remove constants in a PR to 2.2-develop. I would suggest the best case here would be to add a new constant with the correct spelling and then keep the old constant, deprecate it and then use the new constant to give the old constant it's value. Something like:

/**
 * @deprecated see self::SINGLE_PRODUCT_LAYOUT_HANDLE
 */
const SINGLE_PRODUCT_LAYOUT_HANLDE = self::SINGLE_PRODUCT_LAYOUT_HANDLE;

const SINGLE_PRODUCT_LAYOUT_HANDLE = 'catalog_product_view_id_{{ID}}';

This way anyone relying on the old constant will still have the constant but all the magento core code that uses it will have been updated to use the new constant.

[aschrammel]

Hi @dmanners. Thanks for your feedback - I've now deprecated the old constant like you've suggested.

I've already tried to sign the CLA three times - I don't know, why it isn't recognized as signed 😞

EDIT: CLA problem is solved. I missed to set the correct name used for the PR in the profile.