Out of Stock message issue when add child product of Configurable / Bundle product

[hitarthpattani]

I was looking one of Magento issues i.e. #12317 related to out of stock swatch option should be hidden based on selection, but when I tried to reproduce this issue, I get to know there is one more issue with the configurable drop-down attributes. When we assign out of stock simple product variation to the configurable product, it gives the wrong message when we select that combination option and press add to cart button. It should say out of stock product but it says you have not selected an option. The same way, there is an issue with bundle product as well.

## Steps to reproduce

1. Create a configurable product with at least two configurable attributes like "Size" and "Color" with Input Type dropdown.
2. Set one of the child products like "Large Red" to quantity zero and "out of stock."
3. Clear the cache, run the reindex.
4. Go to Configurable Product detail page and select size "Large" and color "Red" and press "Add to Cart". You'll get the error message, "You need to choose options for your item.", but instead, it should "This product is out of stock."
5. Same way, create bundle product with at least two simple products assigned with an option.
6. One of two simple product assigned to bundle product must be out of stock.
7. Clear the cache, run the reindex.
8. Go to Bundle Product detail page and select out of stock simple product from bundle product and press "Add to Cart". You'll get the error message, "The options you selected are not available.", but instead, it should say "This product is out of stock."

## Expected result
When we add the configurable product to cart with out of stock variation, you'll get the error message, "The options you selected are not available.". Same way, when we add bundle product to cart with out of stock child product, you'll get the error message, "The options you selected are not available.".

## Actual result
In both cases, add configurable / bundle product to cart with out of stock variation, the error message should be "This product is out of stock."

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ hitarthkrish
❌ hitarthpattani

[hitarthpattani]

@dmanners There is a Travis CI build failed. It says " 150 | ERROR | [x] Whitespace found at end of line". Do I need to commit code again after removing white space from line 150?

[hitarthpattani]

@magento-engcom-team

Hello Team,

How soon my pull request gets merged? as I have generated this pill request since long. Is there anything that I need to do to make this possible sooner?

Regards
Hitarth

[dmanners]

Hi @hitarthpattani we will process this as soon as we can. Could you first please make sure that you have used the same user for each commit and that this user has signed the cla. Without this we cannot process this pr.

Thank you.

[hitarthpattani]

Hello, @dmanners I have done all the process that was mentioned in this pull request. As I don't have any other user in git, this is the same user who has signed cla and committed the code. Is there any other process that I need to follow apart from this as I see all the three automated checks has already passed. Please let me know. Want to work more with Magento Community.

[dmanners]

Hi @hitarthpattani if you look at the page https://github.com/magento/magento2/pull/13037/commits you will see two commits.

1 is by the user Hitarth Pattani (which is not attached to any github user) and the other is by hitarthpattani which is your git hub users. My guess here is that the user attached to the first commit has a different email address than attached to your github.

I would recommend you have a look through this stackoverflow answer to try and update the first commit to the correct author. https://stackoverflow.com/a/3042512

Thank you

[hitarthpattani]

Hello @dmanners, Can you please confirm that the changes that I have made to change owner name is correct or not? As it seems I have done proper changes. Please let me know as I have one more pull request to submit. Thanks for your support.

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-3103 has been created to process this Pull Request

[slavvka]

Hey @hitarthpattani Thank you for the contribution but we couldn't reproduce the scenario you provided. We did the following:

1. Create a configurable product with two configurable attributes "Size" and "Color" with Input Type dropdown.
2. Set the child products "Large Red" to quantity zero and "out of stock."
3. Go to Configurable Product detail page and select color "Red" and size "Large".
4. Product "Large Red", that is out of stock, doesn't displayed and it is not available to add such option to cart.
   

Could you please verify that the issue still exists?

[slavvka]

hey @hitarthpattani are you going to continue on working on this issue?

[sidolov]

Hi @hitarthpattani , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!