Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple caplitalized words (like typical vendor names) in ACL resource IDs #1397

Merged
merged 3 commits into from
Jul 17, 2015
Merged

Allow multiple caplitalized words (like typical vendor names) in ACL resource IDs #1397

merged 3 commits into from
Jul 17, 2015

Conversation

samtay
Copy link

@samtay samtay commented Jun 21, 2015

The current xsd schema allows for a single capitalized word, followed by an underscore, followed by any mix of lowercase and uppercase letters. All of this is followed by :: and another, more specific string that can contain a mix of lowercase and uppercase letters. For example,

<resource id="Magento_Catalog::attributes_attributes" title="Product" sortOrder="30" />

However, it seems that common practice will be to use the module name Vendor_Module as that first section of the id attribute. Since it is very common for vendor names to be two capitalized words, I've updated the schema to allow for something like below.

<resource id="BlueAcorn_UrlTracker::urltracker" title="URL Tracker" />

To be clear, with the original xsd, the resource ID would have to be Blueacorn_UrlTracker::urltracker, which would cause inconsistent naming across the application.

@Vinai
Copy link
Contributor

Vinai commented Jun 22, 2015

👍 I've also been meaning to send a PR for this :)

@vpelipenko vpelipenko added the PS label Jun 22, 2015
@samtay
Copy link
Author

samtay commented Jul 6, 2015

@Vinai Thanks Vinai! Big fan of yours, much of my Magento knowledge comes from your stack overflow answers.

@vpelipenko Any reason this hasn't been merged yet? Do you need anything else from me?

@magento-team magento-team merged commit 578e419 into magento:develop Jul 17, 2015
magento-team pushed a commit that referenced this pull request Aug 9, 2017
Related Pull Requests

magento/magento2ee#658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants