Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change photo only if user swipe horizontally #14123

Merged
merged 3 commits into from
Mar 22, 2018
Merged

Change photo only if user swipe horizontally #14123

merged 3 commits into from
Mar 22, 2018

Conversation

daniloargentiero
Copy link

Description

Fotorama gallery is too sensitive. This pull request regulates sensitivity to change image only when user swipe horizontally.

Fixed Issues (if relevant)

  1. Fotorama Gallery too sensitive on Android Devices. (chrome) #7906: Fotorama Gallery too sensitive on Android Devices. (chrome)

Manual testing scenarios

  1. Open a product page using an android mobile device
  2. Swipe gallery immages

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

omiroshnichenko
omiroshnichenko previously requested changes Mar 15, 2018
View reviewed changes
Copy link
Contributor

@omiroshnichenko omiroshnichenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, compress fotorama and replace fotorama.min.js with new one.(https://jscompress.com/)

@daniloargentiero
Copy link
Author

Hi @omiroshnichenko,
I compressed the file.

@magento-engcom-team magento-engcom-team added this to the March 2018 milestone Mar 21, 2018
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 22, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 50579a6 into magento:2.3-develop Mar 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Mar 22, 2018
ENGCOM-1006: Change photo only if user swipe horizontally #14123
3bb98db
@daniloargentiero daniloargentiero deleted the issue_7906 branch March 23, 2018 08:32
@daniloargentiero daniloargentiero restored the issue_7906 branch March 23, 2018 08:32
@daniloargentiero daniloargentiero deleted the issue_7906 branch June 7, 2018 15:15
@ihor-sviziev
Copy link
Contributor

Hi @DaniloEmpire,
I think it's really good improvement. Could you also port your fix to 2.2-develop branch?

@Nazar65 Nazar65 mentioned this pull request Apr 1, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omiroshnichenko omiroshnichenko omiroshnichenko approved these changes

Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
March 2018
Development

Successfully merging this pull request may close these issues.
5 participants
@daniloargentiero @ihor-sviziev @omiroshnichenko @sidolov @magento-engcom-team