[Backport] Fix bug with retry connect and custom db port #14753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original Pull Request #14435 Fix a bug in the MySQL adapter when using non standard port Manual testing scenarios Use a database config with port, e.g. localhost:3307 On first call to _connect(), the config['host'] parameter is split into config['host'] and config['port'] In the _query() function, a situation happens that is suitable for a retry (e.g. a "MySQL has gone away" error) _connect() is called again Expected result Connection is reestablished and query tried again Actual result "Port must be configured within host parameter" exception
|
Hi @julienanquetil. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14435
Fix a bug in the MySQL adapter when using non standard port
Manual testing scenarios
Use a database config with port, e.g. localhost:3307
On first call to _connect(), the config['host'] parameter is split into config['host'] and config['port']
In the _query() function, a situation happens that is suitable for a retry (e.g. a "MySQL has gone away" error)
_connect() is called again
Expected result
Connection is reestablished and query tried again
Actual result
"Port must be configured within host parameter" exception
Description
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist