Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Wrong Data On Cart Update Page #14765

Merged
merged 4 commits into from
Apr 22, 2018

Conversation

nit-it
Copy link
Member

@nit-it nit-it commented Apr 19, 2018

If we add configurable product in cart with different options And We need to update 1st item from the cart. So we click edit icon and open Update Cart Page But Quantity and Options display wrong on this page.

Description

This request proposes to set Product options and quantity by checking Item Id.

Fixed Issues (if relevant)

  1. ...

Manual testing scenarios

  1. Create Configurable product.
  2. Add that product in cart with Different options and Quantity.
  3. Now Update 1st item.So click on update item icon.
  4. Update Cart page open .
  5. Quantity and selected option display wrong on this page.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 19, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@nit-it thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@VladimirZaets
Copy link
Contributor

Hi, @nit-it , I made changes in your code, to match with our code standards.
template-security
JS code standart

@magento-engcom-team
Copy link
Contributor

Hi @nit-it. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants