Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI-920: Fixed incorrect test (during order cancellation) #14775

Merged
merged 3 commits into from
Apr 25, 2018

Conversation

seruymt
Copy link
Contributor

@seruymt seruymt commented Apr 19, 2018

Description

Fixed incorrect test (during order cancellation)

Fixed Issues (if relevant)

  1. We can't process inventory cancellation for non existing product (in test - sku: simple2)

Manual testing scenarios

  1. none

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@seruymt
Copy link
Contributor Author

seruymt commented Apr 20, 2018

If we can use the same product Id for order items, then we can use the same Sku

@VladimirZaets
Copy link
Contributor

@seruymt It is incorrect to set the same SKU for two product in an order. You can use another fixture to obtain the same behavior.

@magento-engcom-team
Copy link
Contributor

Hi @seruymt. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants