Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 911 found on MSI project - Cannot read property source_… #14805

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Apr 22, 2018

…code of undefined

Dynamic data rows were failing due to a read after delete condition
Rows were removed just before the information update. An undefined javascript error was triggered.

This issue has ben found in MSI, but it comes from core implementation.

Fixed Issues (if relevant)

  1. Cannot read property source_code of undefined inventory#911: Cannot read property source_code of undefined

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…code of undefined

Dynamic data rows were failing due to a read after delete condition
Rows were removed just before the information update. An undefined javascript error was triggered.
@VladimirZaets
Copy link
Contributor

VladimirZaets commented Apr 22, 2018

Hi, @phoenix128 , thank you for collaboration.
But this fix looks like concatenation of circumstances. According to design of dynamic-rows-grid component we use insertData as single source of data, so shouldn't to be important which operation will be called first.
If _super method will be called first, his will call parent deleteRecord method that will change only recordData property and insertData property shouldn't be affected.

@magento-engcom-team magento-engcom-team merged commit c174682 into magento:2.3-develop Apr 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants