[Forwardport] Add argument on app:config:dump to skip dumping all system settings.

[ihor-sviziev]

Original Pull Request

#12410

Description

Add option config-types on app:config:dump to skip dumping all system settings. That allows to dump only scope, theme for easier maintainability.

Fixed Issues

When using app:config:dump in real projects, we normally do not want to dump all thousands core_config_data settings into config files. That makes the files difficult to read and maintain. Imho dumping scopes and themes makes a lot of sense. However, the system settings should be kept small and simple. They must be progressively added according to project needs.

On the other hand, the main purpose of config.php is to propagate configuration that must be same in all environments, specially for PRD and Build systems. These settings should be just a few, like for example css and js configuration needed for setup:static-content:deploy. Of course others settings might be needed depending on the project but all the others are better managed into core_config_data table or by using setup scripts.

This new option config-types makes possible to dump scopes and themes automatically (needed for build system) while managing system settings manually using config:set --lock-config as requested in PR:

• Add option "lock-config" for shell command "config:set" #12178

It also fixes this issue:

• app:config:dump locks every configuration setting no alternative to dump specific setting only #11396

Manual testing scenarios

Example of workflow on a real project:

0. When creating the project we dump all settings with app:config:dump scopes themes

1. That creates the needed settings for scopes and themes but skips system core config data

2. We also add shared settings needed for PRD and Build environments

   bin/magento config:set --lock-config dev/js/merge_files 1
   bin/magento config:set --lock-config dev/css/merge_css_files 1
   bin/magento config:set --lock-config dev/static/sign 1
   

3. As project evolves, we add a new stores and themes, so we need to update our config.php settings.

   bin/magento app:config:dump  scopes themes
   

4. At the same time, if we ever need to share system settings on all environments, we can use the command bin/magento config:set --lock-config without needing to dump all hundreds of settings into the config.php

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.