Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #14895 - Change Password warning message appear two times #14897

Merged
merged 2 commits into from
May 4, 2018
Merged

Fix issue #14895 - Change Password warning message appear two times #14897

merged 2 commits into from
May 4, 2018

Conversation

phoenix128
Copy link
Contributor

@phoenix128 phoenix128 commented Apr 28, 2018 •
edited
Loading

The password change notice was a sticky message activated by admin_user_authenticate_after event.
The password change page requires the current user password and thus triggering admin_user_authenticate_after while saving.
One message was added every time the user was saved.

Fixed Issues (if relevant)

  1. Change Password warning message appear two times #14895: Change Password warning message appear two times

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@phoenix128
Fix issue magento#14895 - Change Password warning message appear two …
0abb682 
…times

The password change notice was a sticky message activated by admin_user_authenticate_after event.
The password change page requires the current user password and thus triggering admin_user_authenticate_after while saving.
One message was added every time the user was saved.
@sidolov sidolov self-assigned this Apr 29, 2018
@phoenix128
Single call for getMessages()
8d8706e 
app/code/Magento/User/Test/Unit/Observer/Backend/AuthObserverTest.php is checking for a single getMessages() call
@phoenix128 phoenix128 added Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner labels Apr 29, 2018
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 30, 2018
@VladimirZaets VladimirZaets mentioned this pull request May 4, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 8d8706e into magento:2.3-develop May 4, 2018
magento-engcom-team pushed a commit that referenced this pull request May 4, 2018
@VladimirZaets
ENGCOM-1416: Fix issue #14895 - Change Password warning message appea…
ae5cda8 
…r two times #14897
@magento-engcom-team
Copy link
Contributor

Hi @phoenix128. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@sanjay-wagento sanjay-wagento mentioned this pull request Jun 4, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
bugfix Partner: MageSpecialist partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
April 2018
Development

Successfully merging this pull request may close these issues.
4 participants
@phoenix128 @magento-engcom-team @ccasciotti @sidolov