Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX for issue #14849 - In Sales Emails no translation using order.getStatusLabel() #14914

Merged
merged 6 commits into from
Nov 12, 2018
Merged

FIX for issue #14849 - In Sales Emails no translation using order.getStatusLabel() #14914

merged 6 commits into from
Nov 12, 2018

Commits on Apr 30, 2018

  1. FIX for issue magento#14849 - In Sales Emails no translation using or… 

    …der.getStatusLabel()

\Magento\Sales\Model\Order\Config::getStatusLabel(), used by template email was forcing the usage of getLabel() when in adminhtml area.
I added a new method getFrontendStatusLabel() in \Magento\Sales\Model\Order and modified email template files to use it instead of the original implementation.
I did not modify the original implementation because still in use by backend and frontend.
    @phoenix128
    phoenix128 committed Apr 30, 2018
    Configuration menu
    Copy the full SHA
    03e7de4 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2018

  1. FIX cs & docblock

    @phoenix128
    phoenix128 committed May 28, 2018
    Configuration menu
    Copy the full SHA
    5d2b5be View commit details
    Browse the repository at this point in the history

Commits on May 29, 2018

  1. FIX CS

    @phoenix128
    phoenix128 committed May 29, 2018
    Configuration menu
    Copy the full SHA
    1c9ce84 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. Rework without method's contract modification for BW compatibility

    @phoenix128
    phoenix128 committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    18ca5f0 View commit details
    Browse the repository at this point in the history

  2. Missing strict compare in new method

    @phoenix128
    phoenix128 committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    bd80b1a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Missing fallback on AREA_FRONTEND when area is not set

    @phoenix128
    phoenix128 committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    2e634e4 View commit details
    Browse the repository at this point in the history