Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15259 : Unable to disable without providing Industry value #15366

Merged
merged 1 commit into from
Oct 23, 2018
Merged

15259 : Unable to disable without providing Industry value #15366

merged 1 commit into from
Oct 23, 2018

Conversation

sunilit42
Copy link
Contributor

@sunilit42 sunilit42 commented May 19, 2018 •
edited
Loading

Issue :- #15259

Description:-
Solved By:- Adding dependency on the Enabled or disabled field.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@sidolov
Copy link
Contributor

sidolov commented May 20, 2018

Hi @sunilit42 , please, sign CLA, otherwise, we can't process your pull request

@sunilit42
Copy link
Contributor Author

sunilit42 commented May 20, 2018 •
edited
Loading

@sidolov
yes i did please check it

@sunilit42
Copy link
Contributor Author

@sidolov
let me know if any issue.

@magento-engcom-team magento-engcom-team mentioned this pull request May 26, 2018
Closed
4 tasks
@magento-engcom-team
Copy link
Contributor

Similar Pull Request: #15402

@orlangur orlangur self-assigned this Jul 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2271 has been created to process this Pull Request

@okorshenko okorshenko mentioned this pull request Oct 23, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 274fee9 into magento:2.2-develop Oct 23, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2018
ENGCOM-2271: 15259 : Unable to disable without providing Industry value
94a06c0 
#15366
@magento-engcom-team
Copy link
Contributor

Hi @sunilit42. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@slavvka slavvka mentioned this pull request Oct 23, 2018
Closed
4 tasks
@mage2pratik mage2pratik mentioned this pull request Oct 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Award: bug fix Component: Analytics Event: dmcdindia Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.7
Development

Successfully merging this pull request may close these issues.
6 participants
@sunilit42 @magento-cicd2 @sidolov @magento-engcom-team @orlangur @RahulKachhadia