#13685: Upgrading jQuery to 3.3.1 #15531

kirmorozov · 2018-05-26T07:59:28Z

Updating jQuery to 3.3.1 (originally from npm)
Updating jQuery Migrate 3.0.1 (originally from npm)
jQuery Mobile 1.5.0-alpha.1, generated online

Description

Upgrading initial jQuery and jQuery Migrate

In previous series:
#14556
#14637

Fixed Issues (if relevant)

Incompatibilies with jQuery 3 #13685: Incompatibilies with jQuery 3
...

Manual testing scenarios

I can checkout without any problems
I can use admin without any problems

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

* Updating jQuery to 3.3.1 (originally from npm) * Updating jQuery Migrate 3.0.1 (originally from npm)

* Test compatibility for with jQuery 3.x

* Updated jQuery UI to 1.12

+ moved plugin zIndex from previous version

* Fix ajax success in tests.

* Fixing Success/Error as towards done/fail in jQuery 3.x

* File upload success/fail

* Update jQuery UI for backend.

…uery3

magento-engcom-team · 2018-05-26T08:40:33Z

@kirmorozov Closing and reopening Pull Request in order to trigger Travis CI build on it.

kirmorozov · 2018-05-26T18:34:25Z

Work in progress, resolving incompatibility problems with tabs in admin after jQuery-ui update.
from 1.9 to 1.12.

…tabIf generation

kirmorozov · 2018-05-29T11:09:37Z

@Igloczek Hi fellow, how many reviewers must approve to have it merged into the core?

Igloczek · 2018-05-29T12:29:10Z

@kirmorozov It's not defined, only community engineering team decide what should be merged.
The community can just give them advice if something looks good or not.

kirmorozov · 2018-09-04T17:35:08Z

@piotrekkaminski Can you merge it earlier to make sure vendors are compatible when release date comes?

…uery3 # Conflicts: # lib/web/mage/translate-inline.js

Revert "MAGETWO-95280: Storefront Images Don't Scale Back To Original Size In Mobile" This reverts commit 13d360d

kirmorozov · 2018-11-28T23:39:54Z

OK, there was only one bug:
MAGETWO-95280: Storefront Images Don't Scale Back To Original Size In Mobile
Easy one to kill.

ihor-sviziev · 2018-12-14T09:04:48Z

Hi,
Do you think it's a good idea to use "alpha" version of jquery mobile? I think it's better to use latest stable version

…velop-jquery3

sivaschenko · 2019-01-25T16:44:14Z

The pull request was discussed on architecture meeting and it was decided to include it in major 2.4 release magento/architecture#59 (comment)

kirmorozov · 2019-03-26T23:19:28Z

@ihor-sviziev As of jquery mobile, you can check difference yourself, no changes since forever.
jquery-archive/jquery-mobile@1.5.0-alpha.1...1.5.0-rc1

kirmorozov · 2019-04-10T14:49:10Z

Found issue with tabs in admin, resolved here for 2.3.1
https://github.com/morozov-group/magento2-edge/tree/2.3.1-jquery3
Feel free to try on your local

curl https://github.com/magento/magento2/compare/2.3.1...morozov-group:2.3.1-jquery3.patch |\
    sed 's#/app/code/Magento/Catalog/#/vendor/magento/module-catalog/#g' |\
    sed 's#/app/code/Magento/ConfigurableProduct/#/vendor/magento/module-configurable-product/#g' |\
    sed 's#/app/code/Magento/ProductVideo/#/vendor/magento/module-product-video/#g' |\
    sed 's#/app/code/Magento/Theme/#/vendor/magento/module-theme/#g' |\
    sed 's#/app/code/Magento/Ui/#/vendor/magento/module-ui/#g' |\
    sed 's#/app/code/Magento/User/#/vendor/magento/module-user/#g' > _jquery3.patch
patch -p1 --forward < _jquery3.patch

ihor-sviziev

Hi @kirmorozov,
Finally branch 2.4-develop was created, now your PR could be merged! Could you resolve merge conflicts and update to the latest versions.

BassemN · 2019-12-06T02:33:02Z

@kirmorozov please upgrade to jQuery 3.4.1

krzksz

I believe that since jQuery UI modules are now divided into separate files as of a5c6783, this PR has to be reworked.

ihor-sviziev · 2020-02-07T10:20:12Z

Hi @kirmorozov,
Are you interested in finalizing this pull request?
It looks really amazing!

ihor-sviziev · 2020-02-25T15:23:48Z

@kirmorozov Unfortunately I need to close this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

m2-assistant · 2020-02-25T15:23:51Z

Hi @kirmorozov, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

kirmorozov added 11 commits April 5, 2018 12:37

magento#13685:

bcdff33

* Updating jQuery to 3.3.1 (originally from npm) * Updating jQuery Migrate 3.0.1 (originally from npm)

magento#13685:

ccfdcbb

* Test compatibility for with jQuery 3.x

magento#13685:

f9069b9

* Updated jQuery UI to 1.12

magento#13685:

c4c93aa

+ moved plugin zIndex from previous version

magento#13685:

4c7df0a

* Fix ajax success in tests.

magento#13685:

39d3b3a

* Fixing Success/Error as towards done/fail in jQuery 3.x

magento#13685:

9d0837a

* File upload success/fail

magento#13685:

77bdcdb

* Update jQuery UI for backend.

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-jq…

fb1be21

…uery3

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-jq…

d8b9513

…uery3

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-jq…

a9d4485

…uery3

kirmorozov added the mm18it label May 26, 2018

kirmorozov changed the title ~~2.3 develop jquery3~~ #13685: Upgrading jQuery to 3.3.1 May 26, 2018

magento-engcom-team closed this May 26, 2018

magento-engcom-team reopened this May 26, 2018

magento#13685: updated compatibility with jQueryUI 1.12, copied over …

d573eb4

…tabIf generation

kirmorozov force-pushed the 2.3-develop-jquery3 branch from abe87c3 to d573eb4 Compare May 26, 2018 21:13

Igloczek approved these changes May 27, 2018

View reviewed changes

magento-engcom-team assigned VladimirZaets May 30, 2018

magento-engcom-team added this to the Release: 2.3.0 milestone May 30, 2018

magento-engcom-team added Release Line: 2.3 Area: Frontend Area: Lib/Frontend Component: User Component: ProductVideo Component: Theme labels May 30, 2018

magento-engcom-team modified the milestones: Release: 2.3.0, Release: 2.3.1 Sep 18, 2018

sivaschenko added the Progress: on hold label Nov 20, 2018

kirmorozov added 2 commits November 26, 2018 20:44

Merge remote-tracking branch 'origin/2.3-develop' into 2.3-develop-jq…

9e7c810

…uery3 # Conflicts: # lib/web/mage/translate-inline.js

magento#13685: Returned jquery Mobile 1.5.0-alpha.1

430ccdc

Revert "MAGETWO-95280: Storefront Images Don't Scale Back To Original Size In Mobile" This reverts commit 13d360d

sivaschenko mentioned this pull request Jan 11, 2019

January 23, 2019 magento/architecture#59

Closed

Merge branch '2.3-develop' of github.com:magento/magento2 into 2.3-de…

5cd75c6

…velop-jquery3

sivaschenko self-assigned this Jan 25, 2019

okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019

sivaschenko removed the Release Line: 2.3 label Feb 6, 2019

orlangur added the Release Line: 2.4 label Apr 4, 2019

sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 16:01

ihor-sviziev requested changes Dec 5, 2019

View reviewed changes

ghost assigned ihor-sviziev Dec 5, 2019

ghost added Progress: needs update and removed Progress: on hold labels Dec 5, 2019

ihor-sviziev mentioned this pull request Dec 5, 2019

Remove jQuery Migrate #25847

Closed

4 tasks

krzksz suggested changes Dec 7, 2019

View reviewed changes

ghost assigned krzksz Dec 7, 2019

ihor-sviziev closed this Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#13685: Upgrading jQuery to 3.3.1 #15531

#13685: Upgrading jQuery to 3.3.1 #15531

kirmorozov commented May 26, 2018 •

edited by LexKoomen

Loading

magento-engcom-team commented May 26, 2018

kirmorozov commented May 26, 2018

kirmorozov commented May 29, 2018

Igloczek commented May 29, 2018

kirmorozov commented Sep 4, 2018

kirmorozov commented Nov 28, 2018

ihor-sviziev commented Dec 14, 2018

sivaschenko commented Jan 25, 2019

kirmorozov commented Mar 26, 2019

kirmorozov commented Apr 10, 2019

ihor-sviziev left a comment

BassemN commented Dec 6, 2019

krzksz left a comment

ihor-sviziev commented Feb 7, 2020

ihor-sviziev commented Feb 25, 2020

m2-assistant bot commented Feb 25, 2020

#13685: Upgrading jQuery to 3.3.1 #15531

#13685: Upgrading jQuery to 3.3.1 #15531

Conversation

kirmorozov commented May 26, 2018 • edited by LexKoomen Loading

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

magento-engcom-team commented May 26, 2018

kirmorozov commented May 26, 2018

kirmorozov commented May 29, 2018

Igloczek commented May 29, 2018

kirmorozov commented Sep 4, 2018

kirmorozov commented Nov 28, 2018

ihor-sviziev commented Dec 14, 2018

sivaschenko commented Jan 25, 2019

kirmorozov commented Mar 26, 2019

kirmorozov commented Apr 10, 2019

ihor-sviziev left a comment

Choose a reason for hiding this comment

BassemN commented Dec 6, 2019

krzksz left a comment

Choose a reason for hiding this comment

ihor-sviziev commented Feb 7, 2020

ihor-sviziev commented Feb 25, 2020

m2-assistant bot commented Feb 25, 2020

kirmorozov commented May 26, 2018 •

edited by LexKoomen

Loading