Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks to see if the payment is available #15683

Merged
merged 1 commit into from
Oct 10, 2018
Merged

Added checks to see if the payment is available #15683

merged 1 commit into from
Oct 10, 2018

Conversation

michielgerritsen
Copy link
Member

Fix an error while submitting an order without payment method.

Description

When submitting an order using the rest api without an payment, you would get an exception/error report due to the fact there was not payment method.

Fixed Issues (if relevant)

  1. REST API create order POST /V1/orders #15652: REST API create order POST /V1/orders

Manual testing scenarios

  1. Send an POST request to the rest/V1/orders endpoint containing the following:
    { "entity": { "base_grand_total" : 100, "customer_email" : "user@domain.tld", "grand_total" : 100, "items" : [ { "sku" : "TESTSEB" } ] } }

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

@michielgerritsen thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @michielgerritsen. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants