Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix for Wrong price amount on product page #15909

Conversation

gelanivishal
Copy link
Contributor

@gelanivishal gelanivishal commented Jun 7, 2018

Original Pull Request

#15540

Description

This PR fixes broken currency format for some locales.
Since Magento2.2, price in product pages were not shown as expected against integer currencies.

Fixed Issues (if relevant)

  1. Wrong price amount on product page #11717: Wrong price amount on product page

Manual testing scenarios

  1. Create store views for USD(or EUR) and JPY(or KRW, IDR, VND)
  2. Setup currency rates
  3. Create products
  4. Access frontend product page
  5. Price shown as expected format (ex. JPY, KRW, IDR, VND are integer currencies!)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal changed the title Fix for Wrong price amount on product page [Backport] Fix for Wrong price amount on product page Jun 30, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vkublytskyi, thank you for the review.
ENGCOM-2193 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @gelanivishal. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants