Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1164: OnePageCheckoutOfflinePaymentMethodsTest rework to support MSI reservation mechanism. #16164

Merged
merged 3 commits into from
Jun 26, 2018

Conversation

nmalevanec
Copy link
Contributor

Description

Add shipment step to OnePageCheckoutOfflinePaymentMethodsTest in order to support MSI reservation mechanism.

Standard magento behaviour - product quantity decreased immediately after place order, but with MSI quantity decreasing only after shipment created, as MSI introduces additional property for product as 'salable quantity'. And after order placement, 'salable quantity' decreasing, not quantity itself(more about reservation mechanism here). Quantity decreasing only after shipment creation. So, in order to pass OnePageCheckoutOfflinePaymentMethodsTest with MSI, additional step with shipment creation should be added into test before assertions.

Fixed Issues (if relevant)

  1. Fix Functional Test Magento\Checkout\Test\TestCase\OnePageCheckoutOfflinePaymentMethodsTest::test with data set "OnePageCheckoutTestVariation7_0" inventory#1164: Fix Functional Test Magento\Checkout\Test\TestCase\OnePageCheckoutOfflinePaymentMethodsTest::test with data set "OnePageCheckoutTestVariation7_0"

Manual testing scenarios

  1. None.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team mentioned this pull request Jun 26, 2018
@magento-engcom-team magento-engcom-team merged commit a8178be into magento:2.3-develop Jun 26, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @nmalevanec. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hostep
Copy link
Contributor

hostep commented Jun 26, 2018

@magento-engcom-team or @sidolov : you're automated message ended up in issue 1164 of the magento2 repo instead of in the MSI project. Maybe you can make that automated message a bit more intelligent so it posts in the correct repo ;)

@nmalevanec nmalevanec deleted the 1164 branch August 21, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants