Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] [Correct code formatting] #16321

Merged
merged 4 commits into from
Jun 25, 2018
Merged

[Forwardport] [Correct code formatting] #16321

merged 4 commits into from
Jun 25, 2018

Conversation

hitesh-wagento
Copy link
Contributor

@hitesh-wagento hitesh-wagento commented Jun 22, 2018 •
edited by sidolov
Loading

Original Pull Request

#15811

This PR is a:

  • Bug fix or improvement

Summary

Correct Code formatting.

Additional information

NA

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Area: Design/Frontend labels Jun 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 22, 2018
@hitesh-wagento
Copy link
Contributor Author

Hi @VladimirZaets

I have seen below time out error in Travis
The job exceeded the maximum time limit for jobs, and has been terminated.

Could you please check once what cause failed travis?

Thanks

@magento-engcom-team magento-engcom-team merged commit 2dd2c77 into magento:2.3-develop Jun 25, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 25, 2018
ENGCOM-2101: [Forwardport] [Correct code formatting] #16321
08e0aac
@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-code-improvement-new branch September 6, 2018 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hitesh-wagento @magento-engcom-team @VladimirZaets