-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework for PR #16222 . #16393
Rework for PR #16222 . #16393
Conversation
When running 'app:config:dump', admin fields get disabled, but clicking save will process them anyway This behaivour causes a validation check on empty fields since the admin form fields are disabled. This commit checks when the field is read only and skips its save.
Hi @phoenix128. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
I have checked your fix. It's working as expected. Thx for fast response 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi @phoenix128. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Description
When running 'app:config:dump', admin fields get disabled, but clicking save from backend will process them anyway.
This behaivour causes a validation check on empty fields since the admin form fields are disabled and thus validation errors in many cases.
This PR checks when the field is read only and skips its save.
This is a more complete rework for PR #16222 .
Manual testing scenarios
Stores -> Configuration -> General -> Currency Setup
Base Currency
,Default Display Currency
andAllowed Currencies
to whatever you likebin/magento app:config:dump
Contribution checklist