Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it possible to disable cross-sell on cart page #16569

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Make it possible to disable cross-sell on cart page #16569

merged 2 commits into from
Jul 12, 2018

Conversation

arnoudhgz
Copy link
Contributor

@arnoudhgz arnoudhgz commented Jul 5, 2018 •
edited
Loading

Description

To be able to select whether to have the cross-sell active on the cart page an admin configuration is created under Stores > Configuration > Sales > Checkout > Shopping Cart.

The default for this setting is set to Yes (Show cross-sell items). This is for backwards compatibility and not have webshop owners accidentally not showing these items.

Because this is now sorted as the 3rd configuration in this section/group the extra configurations for the grouped product image and the configurable product image are now also increased.

This feature will make it possible to have this cross-sell turned off during special sales, A/B testing or in a specific store view.

Manual testing scenarios

  1. Set up a cross-sell
  2. Add that product that has the cross-sell product configured to your cart
  3. Go to the shopping cart
  4. See that cross-sell is shown
  5. Change the new setting 'Show Crosssell Items in the Shopping Cart' to 'No' (setting is under Stores > Configuration > Sales > Checkout > Shopping Cart)
  6. Refresh affected caches
  7. Go back to the shopping cart
  8. See that cross-sell is not shown

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 5, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Checkout Component: ConfigurableProduct labels Jul 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@arnoudhgz
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz, here is your new Magento instance.
Admin access: https://pr-16569.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

VladimirZaets
VladimirZaets reviewed Jul 6, 2018
View reviewed changes
app/code/Magento/Checkout/etc/adminhtml/system.xml Outdated
@@ -41,6 +41,10 @@
<field id="number_items_to_display_pager" translate="label" type="text" sortOrder="2" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Number of Items to Display Pager</label>
</field>
<field id="crosssell_enabled" translate="label" type="select" sortOrder="3" showInDefault="1" showInWebsite="1" showInStore="1" canRestore="1">
<label>Show Crosssell Items in the Shopping Cart</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the translation to CSV for the new phrase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirZaets Thank you for your feedback, I have added the translation.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 6, 2018
@arnoudhgz
Make it possible to disable cross-sell on cart page
516566a 
To be able to select whether to have the cross-sell active on the cart
page an admin configuration is created under Stores > Configuration >
Sales > Checkout > Shopping Cart.

The default for this setting is set to Yes (Show cross-sell items). This
is for backwards compatibility and not have webshop owners accidentally
not showing these items.

Because this is now sorted as the 3rd configuration in this
section/group the extra configurations for the grouped product image and
the configurable product image are now also increased.

This feature will make it possible to have this cross-sell turned off
during special sales, A/B testing or in a specific store view.
@magento-engcom-team magento-engcom-team merged commit adcb99d into magento:2.3-develop Jul 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 12, 2018
ENGCOM-2205: Make it possible to disable cross-sell on cart page #16569
d0eca97
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@gelanivishal gelanivishal mentioned this pull request Aug 10, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets left review comments

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Component: Checkout Component: ConfigurableProduct Component: GroupedProduct Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arnoudhgz @magento-cicd2 @magento-engcom-team @VladimirZaets