Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Declare module namespace before template path name #16577

Merged
merged 43 commits into from
Jul 6, 2018
Merged

[Backport] Declare module namespace before template path name #16577

merged 43 commits into from
Jul 6, 2018

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#16515

Description

When we override any core block to any custom module, It throws an error because it tries to find template file in the custom module if we do not declare module namespace before template path.
I tried to extend Block Magento\Sales\Block\Order\Creditmemo from my custom module.

1 exception(s): Exception #0 (Magento\Framework\Exception\ValidatorException): Invalid template file: 'form/newsletter.phtml' in module: 'Vendor_Module'

Fixed Issues (if relevant)

Declare module namespace before template path name.
For example: protected $_template = 'Magento_Customer::form/newsletter.phtml';

Manual testing scenarios

Override any block file which content static template file path

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@mageprince
Update AssignProducts.php
50364d1 
Declare module namespace before template path
@mageprince
Update DefaultCaptcha.php
3156f06
@mageprince
Update Tree.php
320748c 
Declare module namespace before template path
@mageprince
Update Chooser.php
2ea290a 
Declare module namespace before template path
@mageprince
Update Edit.php
fff72b6 
Declare module namespace before template path
@mageprince
Update Main.php
534e755 
Declare module namespace before template path
@mageprince
Update Group.php
bf502d4 
Declare module namespace before template path
@mageprince
Update Add.php
c5a77ff 
Declare module namespace before template path
@mageprince
Update Main.php
154cde1
@mageprince
Update Configure.php
c65e4d7 
Declare module namespace before template path
@mageprince
Update Alerts.php
c34bc82 
Declare module namespace before template path
@mageprince
Update Inventory.php
835372f 
Declare module namespace before template path
@mageprince
Update Options.php
e139ab4 
Declare module namespace before template path
@mageprince
Update Websites.php
1f352cf 
Declare module namespace before template path
@mageprince
Update Option.php
fec40bd 
Declare module namespace before template path
@mageprince
Update Date.php
09e2e5b 
Declare module namespace before template path
@mageprince
Update File.php
1756134 
Declare module namespace before template path
@mageprince
Update Select.php
8af67d8 
Declare module namespace before template path
@mageprince
Update Text.php
5b353f4 
Declare module namespace before template path
@mageprince
Update Tier.php
a1ccb20 
Declare module namespace before template path
@mageprince
Update Content.php
964e126 
Declare module namespace before template path
@mageprince
Update Container.php
331c07a 
Declare module namespace before template path
@mageprince
Update Link.php
7a475a7 
Declare module namespace before template path
@mageprince
Update Toolbar.php
1bc1104 
Declare module namespace before template path
@mageprince
Update Additional.php
4bf400d 
Declare module namespace before template path
@mageprince
Update Conditions.php
362b942 
Declare module namespace before template path
@mageprince
Update Conditions.php
1cbcd7c 
Declare module namespace before template path
@mageprince
Update Created.php
ea49cd6 
Declare module namespace before template path
@mageprince
Update Config.php
af5ca55 
Declare module namespace before template path
@mageprince
Update Currency.php
562ad21 
Declare module namespace before template path
@mageprince
Update Matrix.php
fbfdf47 
Declare module namespace before template path
@mageprince
Update Services.php
0f981cf 
Declare module namespace before template path
@mageprince
Update Newsletter.php
abdba4d 
Declare module namespace before template path
@mageprince
Update Newsletter.php
63d0ff9 
Declare module namespace before template path
@mageprince
Update Vat.php
4a4d5e3 
Declare module namespace before template path
@mageprince
Update Downloadable.php
d9f848f 
Declare module namespace before template path
@mageprince
Update Links.php
1f6d6a4 
Declare module namespace before template path
@mageprince
Update Samples.php
6dafb79 
Declare module namespace before template path
@mageprince
Update Js.php
cfdf23d 
Declare module namespace before template path
@mageprince
Update Template.php
d219d1c 
Declare module namespace before template path
@mageprince
Update Edit.php
5a11c63 
Declare module namespace before template path
@mageprince
Update Inline.php
a66dbfd 
Declare module namespace before template path
@mageprince
Update State.php
613b07d 
Declare module namespace before template path
@magento-engcom-team magento-engcom-team added this to the Release: 2.1.15 milestone Jul 6, 2018
@magento-engcom-team magento-engcom-team merged commit 613b07d into magento:2.1-develop Jul 6, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 6, 2018
ENGCOM-2203: [Backport] Declare module namespace before template path…
899a8b7 
… name #16577
magento-engcom-team pushed a commit that referenced this pull request Jul 6, 2018
ENGCOM-2203: [Backport] Declare module namespace before template path…
6d26865 
… name #16577
@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.1.15.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Cleanup Component: Captcha Component: Catalog Component: CatalogWidget Component: ConfigurableProduct Component: CurrencySymbol Progress: accept Release Line: 2.1
Projects
None yet
Milestone
Release: 2.1.15
Development

Successfully merging this pull request may close these issues.
3 participants
@mageprince @magento-engcom-team @sidolov