Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix for #14593 (second try #16431) #16623

Merged
merged 3 commits into from
Jul 11, 2018
Merged

[Forwardport] Fix for #14593 (second try #16431) #16623

merged 3 commits into from
Jul 11, 2018

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#16477

Description

Preconditions:

Magento version 2.2.4 with luma theme

Step to reproduce:

  • Open chrome developer console
  • Add a product to the cart.
  • From the mini cart in the upper right click the trash icon.
  • A confirmation modal will open.
  • Press Esc button

Expected Result

  • Close the confirm

Actual result

  • js error

https://github.com/magento/magento2/blob/2.2-develop/app/code/Magento/Checkout/view/frontend/web/js/sidebar.js#L96

Uncaught TypeError: Cannot read property 'stopImmediatePropagation' of undefined

2018-06-21 15-50-01

Fixed Issues

  1. Press Esc Key on modal generate a jquery UI error #14593

P.S.

First, pull request - #16431

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2219 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @mageprince. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@mageprince mageprince deleted the 2.3-develop-PR-port-16477 branch July 11, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants