Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Variable as a method parameter might be overridden by the loop #16642

Merged
merged 1 commit into from
Jul 11, 2018
Merged

[Forwardport] Variable as a method parameter might be overridden by the loop #16642

merged 1 commit into from
Jul 11, 2018

Conversation

lfluvisotto
Copy link
Contributor

Original Pull Request

#16143

Description

Variable as a method parameter might be overridden by the loop.
Rename the variable in the loop let the code more readable.

@lfluvisotto lfluvisotto requested a review from orlangur July 9, 2018 07:53
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@lfluvisotto lfluvisotto removed the request for review from orlangur July 9, 2018 07:54
@orlangur orlangur self-assigned this Jul 9, 2018
@orlangur orlangur changed the title Variable as a method parameter might be overridden by the loop [Forwardport] Variable as a method parameter might be overridden by the loop Jul 9, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2234 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 9365393 into magento:2.3-develop Jul 11, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2018
ENGCOM-2234: [Forwardport] Variable as a method parameter might be ov…
fab12ad 
…erridden by the loop #16642
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@lfluvisotto lfluvisotto deleted the 2.3-develop-PR-port-16143 branch October 13, 2019 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Component: Bundle Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lfluvisotto @magento-engcom-team @orlangur