Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.3] Add spelling correction: formatedPrice to formattedPrice #16726

Merged
merged 1 commit into from
Jul 13, 2018
Merged

[Backport 2.3] Add spelling correction: formatedPrice to formattedPrice #16726

merged 1 commit into from
Jul 13, 2018

Conversation

arnoudhgz
Copy link
Contributor

Original PR: #16607

Improve code quality with better spelling.

Added new public methods with correct name while added the @deprecated
annotation to the miss-spelled method name. These new old methods return
the new methods.

@arnoudhgz
Add spelling correction: formatedPrice to formattedPrice
1d134da 
Improve code quality with better spelling.

Added new public methods with correct name while added the `@deprecated`
annotation to the miss-spelled method name. These new old methods return
the new methods.
@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Area: Frontend Component: Catalog labels Jul 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@arnoudhgz arnoudhgz changed the title Add spelling correction: formatedPrice to formattedPrice [Backport 2.3] Add spelling correction: formatedPrice to formattedPrice Jul 11, 2018
@VladimirZaets VladimirZaets self-assigned this Jul 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.6 milestone Jul 12, 2018
@magento-engcom-team magento-engcom-team merged commit 1d134da into magento:2.2-develop Jul 13, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 13, 2018
ENGCOM-2290: [Backport 2.3] Add spelling correction: formatedPrice to…
6e70719 
… formattedPrice #16726
@magento-engcom-team
Copy link
Contributor

Hi @arnoudhgz. Thank you for your contribution.
We will aim to release these changes as part of 2.2.6.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@arnoudhgz arnoudhgz deleted the 2.2-develop-PR-port-16607 branch July 13, 2018 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Cleanup Component: Catalog Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@arnoudhgz @magento-engcom-team @VladimirZaets