Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed inactive admin user token #16918

Closed
wants to merge 3 commits into from
Closed

Fixed inactive admin user token #16918

wants to merge 3 commits into from

Conversation

mage2pratik
Copy link
Contributor

@mage2pratik mage2pratik commented Jul 18, 2018

Description

Fixed inactive admin user token error.

Fixed Issues (if relevant)

  1. Can not save an inactive Admin User that has no access tokens generated  #16513: Can not save an inactive Admin User that has no access tokens generated

Manual testing scenarios

  1. Log in to Admin Panel
  2. Navigate to "System" -> "Permissions" -> "All Users"
  3. Click on the inactive Admin User
  4. Click "Save User"

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda
Copy link
Contributor

This is breaking some tests, can you check that? Thanks!

@sidolov
Copy link
Contributor

sidolov commented Aug 6, 2018

@mage2pratik , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 6, 2018
@mage2pratik mage2pratik reopened this Aug 10, 2018
@sidolov
Copy link
Contributor

sidolov commented Aug 14, 2018

Hi @mage2pratik , will you continue the progress with this PR?

@miguelbalparda
Copy link
Contributor

Hi @mage2pratik! Can you please create a port to 2.3? We are trying to have everything merged into that line and then into the rest. Thanks!

@slavvka slavvka self-assigned this Oct 3, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 3, 2018
@magento-engcom-team magento-engcom-team added Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner labels Oct 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-3085 has been created to process this Pull Request

@sivaschenko
Copy link
Member

Closing this pull request as source fork repository was deleted. Feel free to reopen when the source will be restored.

@onepack
Copy link

onepack commented Feb 19, 2020

I'm now running into this with a couple of customers on a B2B webshop.
We are running Magento 2.3.4 How come this issue and fix from july 2018 is not yet merged into the Magento core?
Customers not being able to login seems like a serious enough issue to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants