Migrating Store Grid to UI Components

[afirlejczyk]

Description

Fix sorting by columns in store listing.

I override function joinGroupAndStore in \Magento\Store\Model\ResourceModel\Website\Grid\Collection.
I also use UI component to render store listing instead of block.

Fixed Issues (if relevant)

1. Insignificant stores sorting issue  #7283: Insignificant stores sorting issue

Manual testing scenarios

1. Login to Admin.
2. Go to Stores -> All Stores.
3. Sort by any column.
4. Sorting should work.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[magento-engcom-team]

Hi @afirlejczyk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[afirlejczyk]

I see some tests failed, I will fix this.

[slavvka]

Please fix the issues

[slavvka]

Hey @afirlejczyk Thank you for this huge and meaningful work! But currently there are conflicts with the latest magento code so please merge it and resolve conflicts. Also please look at the changes requested and fix them.

[slavvka]

@afirlejczyk Sure :)

[slavvka]

Hey @afirlejczyk Our internal tests found inconsistency in UI definition:

Passed: 26, Failed: 1, Incomplete: 0, Skipped: 0.
Data set: array (
  'file' => '/var/www/html/app/code/Magento/Store/view/adminhtml/ui_component/store_listing.xml',
  'dataSourceXml' => 
  SimpleXMLElement::__set_state(array(
     '@attributes' => 
    array (
      'name' => 'store_listing_data_source',
      'component' => 'Magento_Ui/js/grid/provider',
    ),
     'settings' => 
    SimpleXMLElement::__set_state(array(
       'storageConfig' => 
      SimpleXMLElement::__set_state(array(
         'param' => 'store_id',
      )),
       'updateUrl' => 
      SimpleXMLElement::__set_state(array(
         '@attributes' => 
        array (
          'path' => 'mui/index/render',
        ),
      )),
    )),
     'dataProvider' => 
    SimpleXMLElement::__set_state(array(
       '@attributes' => 
      array (
        'class' => 'Magento\\Store\\Ui\\DataProvider\\WebsiteDataProvider',
        'name' => 'store_listing_data_source',
      ),
       'settings' => 
      SimpleXMLElement::__set_state(array(
         'requestFieldName' => 'id',
         'primaryFieldName' => 'website_id',
      )),
    )),
  )),
)
UI Component '/var/www/html/app/code/Magento/Store/view/adminhtml/ui_component/store_listing.xml' contains dataSource element without an aclResource```


Could you please fix that?

[slavvka]

Hey @afirlejczyk are you going to proceed with this PR?

[afirlejczyk]

@slavvka yes, I will try to make changes tomorrow or day after tomorrow.

[slavvka]

Hey @afirlejczyk Are you going to proceed with the PR? It is very valuable change that would be very good to complete since there are only few changes left.

[p-bystritsky]

Hey @afirlejczyk Our internal tests found inconsistency in UI definition:

Passed: 26, Failed: 1, Incomplete: 0, Skipped: 0.
Data set: array (
  'file' => '/var/www/html/app/code/Magento/Store/view/adminhtml/ui_component/store_listing.xml',
  'dataSourceXml' => 
  SimpleXMLElement::__set_state(array(
     '@attributes' => 
    array (
      'name' => 'store_listing_data_source',
      'component' => 'Magento_Ui/js/grid/provider',
    ),
     'settings' => 
    SimpleXMLElement::__set_state(array(
       'storageConfig' => 
      SimpleXMLElement::__set_state(array(
         'param' => 'store_id',
      )),
       'updateUrl' => 
      SimpleXMLElement::__set_state(array(
         '@attributes' => 
        array (
          'path' => 'mui/index/render',
        ),
      )),
    )),
     'dataProvider' => 
    SimpleXMLElement::__set_state(array(
       '@attributes' => 
      array (
        'class' => 'Magento\\Store\\Ui\\DataProvider\\WebsiteDataProvider',
        'name' => 'store_listing_data_source',
      ),
       'settings' => 
      SimpleXMLElement::__set_state(array(
         'requestFieldName' => 'id',
         'primaryFieldName' => 'website_id',
      )),
    )),
  )),
)
UI Component '/var/www/html/app/code/Magento/Store/view/adminhtml/ui_component/store_listing.xml' contains dataSource element without an aclResource```


Could you please fix that?

Done.

[m2-assistant]

Hi @afirlejczyk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.