Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Replacing deprecated methods for tests. #17872

Merged
merged 7 commits into from
Sep 6, 2018
Merged

[Backport] Replacing deprecated methods for tests. #17872

merged 7 commits into from
Sep 6, 2018

Conversation

tiagosampaio
Copy link
Member

Original Pull Request

#17645
Replacing deprecated methods for tests.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-2900 has been created to process this Pull Request

@osrecio
Copy link
Member

osrecio commented Aug 31, 2018

@okorshenko @miguelbalparda Maybe is a good idea combine PR: #17871 in this PR.

What do you think?

@okorshenko
Copy link
Contributor

@magento-engcom-team combine 17871

@magento-engcom-team
Copy link
Contributor

Hi @okorshenko. Thank you for your request. I'm working on combining the pull requests for you

@magento-engcom-team
Copy link
Contributor

@tiagosampaio all pull requests have been successfully combined together:

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-2900 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @tiagosampaio. Thank you for your contribution.
We will aim to release these changes as part of 2.2.7.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants