Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#16298 this sould fix the issue and fix a test fails on https://githu… #17980

Closed
wants to merge 2 commits into from

Conversation

molneek
Copy link
Contributor

@molneek molneek commented Sep 8, 2018

…b.com/fratob85/magento2/tree/fix-switch-to-incorrect-store

Description

Fixed Issues (if relevant)

  1. Magento sometimes doesn't select the correct store if the scope code is null #16298: Magento sometimes doesn't select the correct store if the scope code is null
  2. Fixed PR https://github.com/fratob85/magento2/tree/fix-switch-to-incorrect-store

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @molneek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@miguelbalparda miguelbalparda self-assigned this Sep 8, 2018
@miguelbalparda
Copy link
Contributor

Can you please check the failing tests?

@molneek molneek closed this Sep 8, 2018
@molneek molneek deleted the issue-16298-v2.2 branch September 8, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants