Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved: Magento 2.2.5 Product swatches does not show correct value for related store view #17985

Closed
wants to merge 1 commit into from
Closed

Solved: Magento 2.2.5 Product swatches does not show correct value for related store view #17985

wants to merge 1 commit into from

Conversation

jaimin-ktpl
Copy link
Contributor

Description

Updated text swatches data on frontend to get Store view specific titles.

Fixed Issues (if relevant)

  1. Magento 2.2.5 Product swatches does not shows correct value for related store view #17890: Magento 2.2.5 Product swatches does not shows correct value for related store view

Manual testing scenarios

  1. Install fresh magento with default simple data
  2. Edit swatch values for size attribute.
  3. Change value for default store to XS D. And for admin store set XS A
    image
  4. Run bin/magento index:reindex to reindex all indexes
  5. Run bin/magento cache:clean block_html full_page
  6. Check Swatch title on frontend store.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @jaimin-ktpl. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@hostep
Copy link
Contributor

hostep commented Sep 8, 2018

It looks like this is a duplicate of #17891?

@jaimin-ktpl jaimin-ktpl closed this Sep 8, 2018
@jaimin-ktpl jaimin-ktpl deleted the jaimin-ktpl-develop-2.2-patch-17890 branch September 8, 2018 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants