Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend #18196

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend #18196

merged 1 commit into from
Oct 12, 2018

Conversation

bartoszkubicki
Copy link

@bartoszkubicki bartoszkubicki commented Sep 22, 2018 •
edited
Loading

Description

All is described in referenced issue.

Fixed Issues (if relevant)

  1. Custom Product Attribute changes 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend

Manual testing scenarios

Steps are described in referenced issue.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @bartoszkubicki. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento magento deleted a comment from parveen12345 Sep 22, 2018
@sidolov
Copy link
Contributor

sidolov commented Sep 26, 2018

Hi @bartoszkubicki , please, take a look at failed functional tests, looks like those fails caused by the provided implementation.

@bartoszkubicki bartoszkubicki force-pushed the attribute-backend-type-unexpected-change branch from 200bc31 to 08f7ff9 Compare October 2, 2018 17:59
@bartoszkubicki
Copy link
Author

@sidolov all seems to be fixed.

@aleron75 aleron75 self-requested a review October 4, 2018 16:37
@aleron75
Copy link
Contributor

aleron75 commented Oct 4, 2018

Hi @bartoszkubicki!

We are trying to have everything merged on 2.3 before merging it to 2.2 and others.
Thus, I would kindly ask you to change the branch to 2.3.

It's up to you to decide whether to create a new PR or edit this one.

You can easily port PRs to other branches with the Porting Tool, read more here.
Thanks!

@aleron75 aleron75 removed their request for review October 4, 2018 16:40
@bartoszkubicki bartoszkubicki changed the base branch from 2.2-develop to 2.3-develop October 4, 2018 16:44
@bartoszkubicki bartoszkubicki changed the base branch from 2.3-develop to 2.2-develop October 4, 2018 16:45
@bartoszkubicki
Copy link
Author

bartoszkubicki commented Oct 4, 2018 •
edited
Loading

@aleron75 I have tried, but with no luck. If this is going to be merged I will prepare another PR to port it to 2.3. As soon as this one is merged I will create new one (manually if needed) to port to 2.3.

@josefbehr josefbehr self-assigned this Oct 6, 2018
Fix for custom product attribute changing 'backend_type' when 'is_use…
f6a9459 
…r_defined = 1' and get updated/saved in Admin Backend

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend

Fix for custom product attribute changing 'backend_type' when 'is_user_defined = 1' and get updated/saved in Admin Backend
@bartoszkubicki bartoszkubicki force-pushed the attribute-backend-type-unexpected-change branch from 405a2c9 to f6a9459 Compare October 8, 2018 20:58
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 11, 2018
@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3158 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-3158 has been created to process this Pull Request

@sidolov sidolov mentioned this pull request Oct 12, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit f6a9459 into magento:2.2-develop Oct 12, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 12, 2018
ENGCOM-3158: Fix for custom product attribute changing 'backend_type'…
52de41c 
… when 'is_user_defined = 1' and get updated/saved in Admin Backend #18196
@magento-engcom-team
Copy link
Contributor

Hi @bartoszkubicki. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@gelanivishal gelanivishal mentioned this pull request Oct 12, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josefbehr josefbehr josefbehr approved these changes

Assignees

@josefbehr josefbehr

Labels
Award: bug fix Component: Catalog Progress: accept Release Line: 2.2
Projects
None yet
Milestone
Release: 2.2.8
Development

Successfully merging this pull request may close these issues.
5 participants
@bartoszkubicki @magento-engcom-team @sidolov @aleron75 @josefbehr