Use collection _idFieldName by default for toOption* methods.

[colinmollenhour]

This change allows the toOptionArray and toOptionHash methods work for resource collections without having to override these methods for every instance.

[magento-team]

Hello, thanks for the suggestion. We have discussed it but we are rather against changing the abstract super-classes. Can you elaborate what is the primary use of your change?

[colinmollenhour]

The Varien_Data_Collection class uses 'id' as the default $valueField parameter but for super-classes of Varien_Data_Collection_Db the fieldname 'id' is usually not correct. Instead the field is something like entity_id or user_id, etc.. So, with these super-classes the toOptionArray and toOptionHash methods have to be overridden just to specify a different $valueField. Since the id field name is already known (getIdFieldName()), it makes sense to make it the new default rather than just 'id'. Then in a large number of cases the methods will not need to be overridden and they can be used as-is.

So the primary use of the change is just to reduce the need to override methods where it would otherwise not be necessary as the toOptionArray and toOptionHash methods are useful for many collections.

Example:

$categoryNames = Mage::getResourceModel('Mage_Catalog_Model_Resource_Category_Collection')->toOptionHash();

The above does not work before my patch and should work after my patch.

[verklov]

Hello colinmollenhour,
We have processed your pull request. The code should be available in the code version dev53 released last Friday.

Thank you for your contribution!