Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wysiwyg editor not decoding base64 filenames special chars #18215

Merged
merged 2 commits into from
Sep 28, 2018
Merged

fix wysiwyg editor not decoding base64 filenames special chars #18215

merged 2 commits into from
Sep 28, 2018

Conversation

adammada
Copy link

Description

Properly decode base64 special chars in TinyMCE. Whole part of code was changed in 2.3, but it is not working in 2.2

Fixed Issues (if relevant)

  1. WYSIWYG editor fails to parse directives of files with special characters in URL (so random files) #18138: WYSIWYG editor fails to parse directives of files with special characters in URL (so random files)

Manual testing scenarios

  1. WYSIWYG editor fails to parse directives of files with special characters in URL (so random files) #18138

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @adammada. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3054 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@adammada thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @adammada. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants