Allow user defined dropdown attributes to be searchable with Elasticsearch

[luckyraul]

In elasticsearch currently we have index created for drop-down attribute

"brand_value": "Nivea",
"brand": "38156"

Magento is searching with this request

            {
               "match":{
                  "brand":{
                     "query":"Nivea",
                     "boost":10
                  }
               }
            }

instead of

            {
               "match":{
                  "brand_value":{
                     "query":"Nivea",
                     "boost":10
                  }
               }
            }

If I update attribute to is_user_defined = 0, search request is correct.

[magento-cicd2]

All committers have signed the CLA.

[rogyar]

Hi @luckyraul. Please, provide the PR description according to the template so we can analyze the information and perform the proper testing steps. You can take a look at another PR for an example (#17968). Thank you

[luckyraul]

@rogyar is it enough?

[sivaschenko]

I don't see any need in isUserDefined check here

[magento-engcom-team]

Hi @sivaschenko, thank you for the review.
ENGCOM-3402 has been created to process this Pull Request

[magento-engcom-team]

@luckyraul thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[sivaschenko]

@luckyraul can you please add steps to test the actual problem to help with the QA for this issue.

[sivaschenko]

@luckyraul closing this pull request as the issue cannot be reproduced on the latest 2.3 Magento, looks like already fixed by the core team (https://github.com/magento/magento2/search?q=MAGETWO-94482&type=Commits). Please feel free to reopen and provide more details if you are able to reproduce the problem on the latest codebase.