Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] 17968 Fix Customer custom attributes lost after save #18373

Closed
wants to merge 4 commits into from
Closed

[Forwardport] 17968 Fix Customer custom attributes lost after save #18373

wants to merge 4 commits into from

Conversation

Thundar
Copy link
Contributor

@Thundar Thundar commented Oct 4, 2018 •
edited
Loading

Description

Up porting #17968

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@Thundar Thundar changed the title Up port pull 17968 [Forwardport] 17968 Fix Customer custom attributes lost after save Oct 4, 2018
@rogyar rogyar self-assigned this Oct 4, 2018
@rogyar
Copy link
Contributor

rogyar commented Oct 4, 2018

Hi @Thundar. I'm putting this PR on hold. We need to wait until the original PR is merged. Thank you

@Thundar Thundar mentioned this pull request Oct 4, 2018
Merged
4 tasks
@Thundar
Copy link
Contributor Author

Thundar commented Oct 4, 2018

A test failed on PHP docs that are not depending by this PR. To avoid conflicts, I submitted a different PR to fix them: #18386

@Thundar Thundar added partners-contribution Pull Request is created by Magento Partner Partner: The Site Up labels Oct 11, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3350 has been created to process this Pull Request

@sidolov
Copy link
Contributor

sidolov commented Dec 10, 2018

Hi @Thundar , looks like we merged another port of original PR first: #18571 but don't worry, you have already received points for ported PR made by the other contributor according to our rules.
I'm sorry about that, we will try to avoid such situations in the future.
Thank you for your contribution!

@sidolov sidolov closed this Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov approved these changes

Assignees

@rogyar rogyar

@sidolov sidolov

Labels
Component: Customer Partner: The Site Up partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@Thundar @rogyar @magento-engcom-team @sidolov