Correct spelling #18442
Closed
Correct spelling #18442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hugovk! Can you please check the failing tests? Thank you! |
|
@miguelbalparda Will do. That's strange they didn't fail on my fork: https://travis-ci.org/hugovk/magento2/builds/438317027 There's probably also some bug in the build scripts which meant it didn't fail when it should, compare: https://travis-ci.org/magento/magento2/jobs/438331102#L948 |
2 tasks
|
@hugovk, "Fix Code Sniffer using PHPCBF" - please avoid such changes or at least don't use rules not used in Magento, like PHPDoc alignment. |
|
Closing this, I didn't get time to tidy it up and it's since got to merge conflict hell, but at least some of it was merged in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct spelling mistakes.
Manual testing scenarios
Contribution checklist