Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Added option to exclude discount amount from minimum order amount calculation #18524

Merged

Conversation

ccasciotti
Copy link
Contributor

@ccasciotti ccasciotti commented Oct 11, 2018

Original pull request: #19136

Description

This PR adds option for store manager to include or exclude discount amount from minimum order amount calculation. Sometimes client wants to exclude discount amount from minimum order and want that only subtotal is used. The default option is set to "Yes" so Magento will use the current behavior.

Fixed Issues (if relevant)

none

Manual testing scenarios

  1. Access backend
  2. Go to Stores > Configuration > Sales > Sales > Minimum Order Amount
  3. Leave "Yes" in "Include Discount Amount" field to test normal behavior.
  4. Set "No" in "Include Discount Amount" field to test new behavior without discount.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@ccasciotti
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ccasciotti. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ccasciotti, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18524//admin
Login: admin Password: 123123q

@ccasciotti
Copy link
Contributor Author

@magento-engcom-team manual test was successful, please review code

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nowadays all changes must be applied to 2.3-develop first (see https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#rules). Please prepare a new pull request, this one should be on hold until the latter is merged.

@sivaschenko sivaschenko changed the title Added option to exclude discount amount from minimum order amount calculation [Backport] Added option to exclude discount amount from minimum order amount calculation Jan 26, 2019
@ccasciotti
Copy link
Contributor Author

Hi @orlangur,
I've ported the change request's commit of the merged #19136 PR here, you can review code and eventually unlock this PR for the 2.2-develop.

Thanks.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3986 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@ccasciotti ccasciotti removed the request for review from rogyar January 29, 2019 09:12
@magento-engcom-team magento-engcom-team merged commit aa87475 into magento:2.2-develop Feb 11, 2019
@ghost
Copy link

ghost commented Feb 11, 2019

Hi @ccasciotti, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 11, 2019
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants