-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Added option to exclude discount amount from minimum order amount calculation #18524
[Backport] Added option to exclude discount amount from minimum order amount calculation #18524
Conversation
@magento-engcom-team give me test instance |
Hi @ccasciotti. Thank you for your request. I'm working on Magento instance for you |
Hi @ccasciotti, here is your new Magento instance. |
@magento-engcom-team manual test was successful, please review code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nowadays all changes must be applied to 2.3-develop
first (see https://devdocs.magento.com/guides/v2.3/contributor-guide/contributing.html#rules). Please prepare a new pull request, this one should be on hold
until the latter is merged.
Hi @sidolov, thank you for the review. |
Hi @ccasciotti, thank you for your contribution! |
…minimum order amount calculation #18524
Original pull request: #19136
Description
This PR adds option for store manager to include or exclude discount amount from minimum order amount calculation. Sometimes client wants to exclude discount amount from minimum order and want that only subtotal is used. The default option is set to "Yes" so Magento will use the current behavior.
Fixed Issues (if relevant)
none
Manual testing scenarios
Contribution checklist